Skip to content

chore(lint): generate content-collections before tsc/lint#896

Merged
tannerlinsley merged 1 commit intomainfrom
taren/compassionate-davinci-89596a
May 7, 2026
Merged

chore(lint): generate content-collections before tsc/lint#896
tannerlinsley merged 1 commit intomainfrom
taren/compassionate-davinci-89596a

Conversation

@tannerlinsley
Copy link
Copy Markdown
Member

@tannerlinsley tannerlinsley commented May 7, 2026 •
edited by coderabbitai Bot
Loading

Summary

  • Adds a content:build script that runs the @content-collections/core builder, plus a pretest hook so pnpm test regenerates .content-collections/generated/ before running tsc and lint.
  • Without this, standalone tsc/lint runs from a fresh clone fail to resolve the content-collections module (only Vite's dev/build pipeline generates that folder), surfacing as TS2307 and downstream implicit-any errors in src/utils/blog.ts and src/utils/blog.functions.ts.

Test plan

  • pnpm lint passes (0 errors)
  • pnpm test (tsc + lint) passes from a clean state with .content-collections/ deleted

Summary by CodeRabbit

Chores

  • Modified the test execution workflow to automatically prepare content collections before running tests, ensuring all required dependencies are available during test execution
  • Enhanced development infrastructure with new build automation capabilities, streamlining the process of preparing content collections as part of the development pipeline

@tannerlinsley
chore(lint): generate content-collections before tsc/lint
ee26286 
Adds a `content:build` script and `pretest` hook so `pnpm test` works
from a fresh clone. The `.content-collections/generated/` folder is
otherwise only produced by Vite during dev/build, leaving standalone
tsc and lint runs unable to resolve the `content-collections` module.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 7, 2026

❌ Deploy Preview for tanstack failed. Why did it fail? →

Name Link
🔨 Latest commit ee26286
🔍 Latest deploy log https://app.netlify.com/projects/tanstack/deploys/69fc23cc9202af0008da957d

1 similar comment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 7, 2026

❌ Deploy Preview for tanstack failed. Why did it fail? →

Name Link
🔨 Latest commit ee26286
🔍 Latest deploy log https://app.netlify.com/projects/tanstack/deploys/69fc23cc9202af0008da957d

@tannerlinsley tannerlinsley merged commit 06932e7 into main May 7, 2026
3 of 8 checks passed
@tannerlinsley tannerlinsley deleted the taren/compassionate-davinci-89596a branch May 7, 2026 05:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026 •
edited
Loading

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc35cdfb-0eb1-488a-aa24-dd1a3e3f9979

📥 Commits

Reviewing files that changed from the base of the PR and between e238f28 and ee26286.

📒 Files selected for processing (2)
  • package.json
  • scripts/build-content-collections.mjs
📝 Walkthrough

Walkthrough

A new build script for content collections is added to package.json and integrated into the npm test lifecycle. The scripts/build-content-collections.mjs builder imports @content-collections/core, resolves the content-collections.ts configuration, and executes an asynchronous build. A pretest lifecycle hook ensures the build runs before tests.

Changes

Content Collections Build Setup

Layer / File(s) Summary
Build Script Definition
package.json		 The content:build npm script is added to invoke node scripts/build-content-collections.mjs.
Build Implementation
scripts/build-content-collections.mjs		 ESM script creates a builder from @content-collections/core, resolves the content-collections.ts configuration path, and awaits completion of builder.build().
Test Lifecycle Integration
package.json		 The pretest npm lifecycle script is added to automatically run pnpm run content:build before the test suite.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A builder's tale in script so bright,
Content collections take their flight,
Before the tests run, content's made,
In pretest hooks, the groundwork's laid!
With async calls and paths resolved,
The build pipeline's now evolved. 🎉

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/compassionate-davinci-89596a

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tannerlinsley